🐛 fix: do not include agent if scope is only Test #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized it may be worth adding a word in the README about this behaviour. Let me know what you think :) EDIT: added a sentence. |
gaeljw
commented
Aug 10, 2025
| @@ -37,6 +37,8 @@ This will automatically resolve the agent module, bundle the agent artifact in t | |||
|
|
|||
| By default, sbt-javaagent will only add an agent to distributions. Agents can be optionally enabled for compile, run, or test. | |||
|
|
|||
| > **Note**: starting from v0.2.0, if the agent is only in `test` scope, it won't be added do distributions. You can set the scope to `dist;test` to retain the previous behaviour. | |||
There was a problem hiding this comment.
ℹ️ I assume this PR would be released as a new minor, feel free to change this line if you prefer to release it as bugfix.
There was a problem hiding this comment.
We need to release at least a new minor version because in main branch we also dropped support for SBT 0.13.
Will take a look at this pr soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #36
I've added 2 test projects:
Testscope => the java agent should not be added in distributionsTestscope but also another scope => the java agent is added in distributionsThe 2nd case is so that this fix is not a breaking change: users are used to not have to explicitly set the "dist" scope and get the java agent added by default. This behaviour is also covered implicitly by other existing test projects but I preferred adding one explicitly for that.